[Windows] ClangImporter: Work around duplicate link declaration error… #84017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
Xazax-hun,
beccadax,
egorzhdan,
fahadnayyar,
ian-twilightcoder,
j-hui,
susmonteiro and
zoecarver
as code owners
|
@swift-ci please smoke test |
compnerd
approved these changes
Aug 29, 2025
… in implicit modulemaps swiftlang/llvm-project#11265 broke Windows CI for rebranch because our Windows modulemaps contain implicit submodules with link declarations. This is a temporary workaround to unblock investigation on any downstream issues.
AnthonyLatsis
force-pushed
the
jepa-rebranch
branch
from
e8b392d to
c66dde4
Compare
|
@swift-ci please test Windows |
|
BTW, I think that we should drop the |
|
swiftlang/llvm-project#11265 was reverted in swiftlang/llvm-project#11310. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in implicit modulemaps
swiftlang/llvm-project#11265 broke Windows CI for rebranch because our Windows modulemaps contain implicit submodules with link declarations. This is a temporary workaround to unblock investigation on any downstream issues.